Skip to content

fix: relax :global selector list validation #15762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

fix: relax :global selector list validation #15762

merged 1 commit into from
Apr 14, 2025

Conversation

dummdidumm
Copy link
Member

We have to allow :global x, :global y selector lists because CSS preprocessors might generate that from :global { x, y {...} }

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm
fix: relax :global selector list validation
8c35999 
We have to allow `:global x, :global y` selector lists because CSS preprocessors might generate that from `:global { x, y {...} }`
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

🦋 Changeset detected

Latest commit: 8c35999

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-svelte-15762-svelte.vercel.app/

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15762

@Rich-Harris Rich-Harris merged commit a051f96 into main Apr 14, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the global-selector-list branch April 14, 2025 18:38
@github-actions github-actions bot mentioned this pull request Apr 14, 2025
Merged
@paoloricciuti paoloricciuti mentioned this pull request Apr 22, 2025
Closed
dummdidumm added a commit that referenced this pull request Apr 22, 2025
@dummdidumm
fix: don't mark selector lists inside :global with multiple items a…
26d9a9a 
…s unused

Regression from #15762

Fixes #15816
@dummdidumm dummdidumm mentioned this pull request Apr 22, 2025
Merged
6 tasks
dummdidumm added a commit that referenced this pull request Apr 22, 2025
@dummdidumm
fix: don't mark selector lists inside :global with multiple items a…
5692de7 
…s unused

Regression from #15762

Fixes #15816
paoloricciuti pushed a commit that referenced this pull request Apr 22, 2025
@dummdidumm
fix: don't mark selector lists inside :global with multiple items a…
dfd742d 
…s unused (#15817)

Regression from #15762

Fixes #15816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dummdidumm @Rich-Harris